Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

C compatibility fixes #1698

Merged
merged 1 commit into from
Nov 22, 2023
Merged

C compatibility fixes #1698

merged 1 commit into from
Nov 22, 2023

Conversation

fweimer-rh
Copy link
Contributor

Most compilers currently accept arbitrary identifiers in this place
and ignore then, but this is going to change and turn into an error.
(It prevents compilers from diagnosing misspelled type names,
and the resulting declaration is not a prototype, so no type
errors will be reported at call sites.)
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fixes. One of them doesn't look quite right, though. Please have another look.

cmake/Modules/FindIconv.cmake Outdated Show resolved Hide resolved
unix/xserver/hw/vnc/vncModule.c Show resolved Hide resolved
Copy link
Member

@CendioOssman CendioOssman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks!

@CendioOssman CendioOssman merged commit 9cff04c into TigerVNC:master Nov 22, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants