Add basic DRI3 support #1771
Merged
Add basic DRI3 support #1771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Windows aren't always directly shown, e.g. when the desktop is composited. We should not be sending screen updates for these as the framebuffer didn't actually change. In the case of CopyWindow, we're even sending the wrong screen data, which is how this bug was discovered.
It was incorrectly designed to only build properly if built as part of the "Xorg" server and could fail to build when just "Xvnc" was built. Backport of upstream commits 0ce93e5 and acc581c.
This provides buffer sync with the primary render node of the system (if available). By doing so, OpenGL and Vulkan can use the render node for acceleration. This first implementation is extremely pessimistic and synchronises buffers whenever there's even a slight chance they will be used.
One GNOME developer had a bad experience with VNC one time, and therefore all VNC must forever be punished. Avoid detection by GNOME so that animations aren't forcefully disabled without any option for the user to re-enable them.
Allows users to use a secondary GPU, or to disable DRI3 in case of issues.
Lay the groundwork for a more intelligent selection of GPU in systems that have multiple cards. This initial implementation simply picks the first GPU that we have permission to open.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This provides buffer sync with a render node of the system (if available). By doing so, OpenGL and Vulkan can use the render node for acceleration.
This first implementation is extremely pessimistic and synchronises buffers whenever there's even a slight chance they will be used. Performance is still quite good in most cases.