rename class, resolves todo

TilmanNeumann · Dec 31, 2024 · 51afa88 · 51afa88
1 parent cad021d
commit 51afa88
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 14 deletions.
diff --git a/src/main/java/de/tilman_neumann/jml/quadraticResidues/QuadraticResidues.java b/src/main/java/de/tilman_neumann/jml/quadraticResidues/QuadraticResidues.java
@@ -15,22 +15,13 @@
 
 import java.util.TreeSet;
 
-import org.apache.logging.log4j.Logger;
-import org.apache.logging.log4j.LogManager;
-
 /**
  * Methods to generate quadratic residues or test for quadratic residuosity for general moduli m.
  * 
  * @author Tilman Neumann
  */
 public class QuadraticResidues {
 
-	@SuppressWarnings("unused")
-	private static final Logger LOG = LogManager.getLogger(QuadraticResidues.class);
-
-	@SuppressWarnings("unused")
-	private static final boolean DEBUG = false;
-
     /**
      * Return all quadratic residues modulo m, computed by brute force.
      * 

diff --git a/...sidues/QuadraticResiduesMod2PowNTest.java → ...draticResidues/QuadraticResiduesTest.java b/...sidues/QuadraticResiduesMod2PowNTest.java → ...draticResidues/QuadraticResiduesTest.java
@@ -26,13 +26,13 @@
 import de.tilman_neumann.util.ConfigUtil;
 
 /**
- * Test quadratic residue computations modulo 2^n.
+ * Tests for class QuadraticResidues.
  * 
  * @author Tilman Neumann
  */
-public class QuadraticResiduesMod2PowNTest {
+public class QuadraticResiduesTest {
 
-	private static final Logger LOG = LogManager.getLogger(QuadraticResiduesMod2PowNTest.class);
+	private static final Logger LOG = LogManager.getLogger(QuadraticResiduesTest.class);
 
 	private static final boolean DEBUG = false;
 
@@ -42,7 +42,6 @@ public static void setup() {
 	}
 
 	@Test
-	// TODO this test must be moved to another class because m=100 is not of the form 2^n
 	public void testSetOfQuadraticResidues() {
 		TreeSet<Long> quadraticResiduesMod100 = QuadraticResidues.getQuadraticResidues(100);
 		LOG.info("m = 100 has " + quadraticResiduesMod100.size() + " quadratic residues: " + quadraticResiduesMod100);
@@ -56,7 +55,7 @@ public void testSetOfQuadraticResidues() {
 	 * a(n) = {1, 1} + A023105(n-2) = 1, 1, 1, 2, 2, 3, 4, 7, 12, 23, 44, 87, 172, 343, 684, 1367, 2732, 5463, 10924, 21847, ... for "even" quadratic residues modulo 2^n.
 	 */
 	@Test
-	public void testQuadraticResidueCounts() {
+	public void testQuadraticResiduesMod2PowNCounts() {
 		ArrayList<Integer> counts = new ArrayList<Integer>();
 		ArrayList<Integer> evenCounts = new ArrayList<Integer>();