Give it more memory to see if GC overhead is behind the instability

TimefoldAI · Sep 30, 2024 · ced00ed · ced00ed
1 parent 82e447c
commit ced00ed
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 11 deletions.
diff --git a/.github/workflows/performance_score_director.yml b/.github/workflows/performance_score_director.yml
@@ -124,22 +124,22 @@ jobs:
           export RUN_ID="${{github.workflow.inputs.branch}}"
           ./run-scoredirector.sh
 
+      - name: Phase 3 - Archive benchmark data
+        uses: actions/upload-artifact@v4
+        with:
+          name: results-${{ matrix.example }}-${{ github.event.inputs.baseline }}_vs_${{ github.event.inputs.branch }}
+          path: |
+            ./timefold-solver-benchmarks/results
+
       - name: Phase 3 - Publish benchmark result
         uses: benchmark-action/github-action-benchmark@v1
         with:
           name: scoredirector-${{ matrix.example }}
           tool: 'jmh'
-          output-file-path: ./timefold-solver-benchmarks/results/results.json
-          github-token: ${{ secrets.JRELEASER_GITHUB_TOKEN }}
+          output-file-path: ./timefold-solver-benchmarks/results/${{ github.event.inputs.branch }}/results.json
+          github-token: ${{ secrets.BENCHMARK_PUBLISH_TOKEN }}
           auto-push: true
           alert-threshold: '105%'
           comment-on-alert: true
           fail-on-alert: true
-          alert-comment-cc-users: '@triceo'
-
-      - name: Phase 3 - Archive benchmark data
-        uses: actions/upload-artifact@v4
-        with:
-          name: results-${{ matrix.example }}-${{ github.event.inputs.baseline }}_vs_${{ github.event.inputs.branch }}
-          path: |
-            ./timefold-solver-benchmarks/results
+          alert-comment-cc-users: '@triceo'
diff --git a/src/main/java/ai/timefold/solver/benchmarks/micro/common/AbstractMain.java b/src/main/java/ai/timefold/solver/benchmarks/micro/common/AbstractMain.java
@@ -178,7 +178,7 @@ public ChainedOptionsBuilder getBaseJmhConfig(C configuration) {
                 .forks(configuration.getForkCount())
                 .warmupIterations(configuration.getWarmupIterations())
                 .measurementIterations(configuration.getMeasurementIterations())
-                .jvmArgs("-XX:+UseParallelGC", "-Xms1g", "-Xmx1g") // Minimize GC overhead.
+                .jvmArgs("-XX:+UseParallelGC", "-Xmx2g") // Minimize GC overhead.
                 .result(resultsDirectory.resolve("results.json").toAbsolutePath().toString())
                 .resultFormat(ResultFormatType.JSON)
                 .shouldDoGC(true);