Avoid resetting cursor on no-op seek #334
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The implementation of
seek
had the defective property that when the seek was a no-op, for example when one re-issued a seek to the same key multiple times in sequence, the child cursor (over associated values, say) would be reset each time. I judge the correct implementation of seek to not do this, so as to present a continually advancing cursor. One can always rewind a cursor's values if that is what you want. (of course, one could always test if you are at the correct key and notseek
as well).