Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

join: simplify logic passed to Deferred::work #392

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

join: simplify logic passed to Deferred::work #392

wants to merge 1 commit into from

Commits on Jun 5, 2023

  1. join: simplify logic passed to Deferred::work 

    Previously, the join code had to wrap the `result` closure into
another closure to invoke `Deferred::work`, to deal with the fact that
matches from the `todo1` list had their value and diff fields swapped.

Instead of having a closure to unswap the fields, we can simply pass
them to the `Deferred` constructor in the correct order instead. That
is, the `Deferred` constructor should always receive the cursor/storage
from input 1 first and from input 2 second. If we make this change, then
a) no swapping closure is necessary, and b) the input values match the
types (`C1`, `C2`) of the `Deferred` struct.
    @teskje
    teskje committed Jun 5, 2023
    Configuration menu
    Copy the full SHA
    0e0493a View commit details
    Browse the repository at this point in the history