Implement Quotes Board #1029
Open
Implement Quotes Board #1029
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tj-wazei
requested changes
Mar 1, 2024
application/src/main/java/org/togetherjava/tjbot/features/Features.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
tj-wazei
reviewed
Mar 1, 2024
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Show resolved
Hide resolved
christolis
force-pushed
the
feature/cool-messages
branch
from
4a68771
to
bc3b7d6
Compare
christolis
force-pushed
the
feature/cool-messages
branch
from
35ba891
to
47cdcb2
Compare
Taz03
requested changes
Mar 20, 2024
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
application/src/main/java/org/togetherjava/tjbot/features/basic/CoolMessagesBoardManager.java
Outdated
Show resolved
Hide resolved
christolis
force-pushed
the
feature/cool-messages
branch
from
47cdcb2
to
6d86c8f
Compare
Taz03
previously approved these changes
Apr 14, 2024
Fixes a bug where any user could star react to a message and the bot would unconditionally add that message to the cool messages board, considering the fact that it would surpass the minimum reaction count requirement. This commit gets the bot to react with the same cool messages emoji the first time and use that reaction as proof that it has quoted the message and that it should not deal with it in case somebody reacts to it again.
By the time we need to get the contents of boardChannel when we attempt to insert the cool message, the boardChannel's optional will never be empty, so use Optional#get() instead.
christolis
force-pushed
the
feature/cool-messages
branch
from
ed3dbd5
to
59dc245
Compare
ankitsmt211
added
the
config-changes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1027.
Screenshots
Configuration changes
coolMessagesConfig.minimumReactionfor the target message to
be considered to the board channel.
coolMessagesConfig.boardChannelPatternthat should be quoted get posted to.
"quotes"