Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynamically create and delete voice channels based on activity #1114

Open
wants to merge 9 commits into
base: develop
Choose a base branch
from
Open

Dynamically create and delete voice channels based on activity #1114

wants to merge 9 commits into from

Conversation

christolis
Copy link
Member

@christolis christolis commented May 14, 2024 •
edited
Loading

Closes #1113.

Media

output

Configuration changes

Property Description Type
dynamicVoiceChannelPatterns List of voice channel patterns to manage dynamically. List[String]

@christolis
feat: add ability to handle voice events
34e42d5 
This commit aims to add functionality for developers to create their own
voice receiver features that deal with events regarding Discord voice
channels.

It is implemented here since we need to handle such events for
the purposes of dynamically creating and deleting voice channels on
demand when guild members perform actions involving them, like
connecting, disconnecting, or moving between them.
@christolis christolis added the enhancement New feature or request label May 14, 2024
@christolis christolis self-assigned this May 14, 2024
@christolis christolis marked this pull request as ready for review May 15, 2024 15:27
@christolis christolis requested a review from a team as a code owner May 15, 2024 15:27
@tj-wazei
Copy link

I haven't looked at the code yet but I have some suggestions for the functionality.

  • We should have a new Voice Chat that's more descriptive on "hey you're about to create a new voice channel". Maybe something like "New Voice Channel" instead of using Chit Chat.
  • The new room should be based on the "creators" name e.g. "Christolis's Room" and it should automatically move you from the "New Voice Channel" to "Christolis's Room" (people can rename after as needed)
  • We should have a cleanup task e.g. if a voice channel has been empty for 5 minutes then it should be deleted.

Importantly, the existing channels should be protected from the changes that get implemented here.

This is just an IMO - we should wait for further feedback first.

@christolis christolis marked this pull request as draft May 15, 2024 21:29
@christolis
feat: implement rate limit solution
ed46d62 
This commit slows down the processing of event queues for the sole
purpose of preventing Discord API endpoint saturation as well as to
avoid the global Discord API Gateway rate limiter.

Moreover, it removes a few 'static' keywords that should not be there.
@christolis christolis marked this pull request as ready for review May 16, 2024 08:26
@ankitsmt211
Copy link
Member

I love @tj-wazei suggestions, we shouldnt delete channels immediately and one more thing to add. We also wanna cap channel count to a certain limit. For example we can't have more than say 3 channels per category for now. We can put this limit in configuration so it's easily tweaked without making changes to code by maintainers.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@christolis christolis

Labels
enhancement New feature or request
Projects
Together Java
Status: In Progress
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dynamically create and delete voice channels based on activity
3 participants
@christolis @tj-wazei @ankitsmt211