New jsons for including extensions in the same jsons as the original sample, and updated #449
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #449 +/- ##
=======================================
Coverage 26.24% 26.24%
=======================================
Files 31 31
Lines 4747 4747
=======================================
Hits 1246 1246
Misses 3501 3501
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bryates
reviewed
Dec 12, 2024
input_samples/sample_jsons/background_samples/central_2022/CheckJsons.py
Show resolved
Hide resolved
bryates
reviewed
Dec 16, 2024
| @@ -0,0 +1,37 @@ | |||
| import os | |||
There was a problem hiding this comment.
I'm curious what this file is for. Did some of the central samples go missing after we made the json files? If so, does this properly fix the sum of weights, or should we rerun make_jsons.py instead?
There was a problem hiding this comment.
@bryates yes, we have seen that some of them are missing, so this is a temporary fix. We need for sure rerun make_jsons. In addition, we should recopy the missing files, but considering that we are going to run the skimming procedure with the new ttH MVA on top of the Run3 samples, I would avoid to recopy the missing central files and directly wait for the skimmed samples. What do you think?
There was a problem hiding this comment.
We'll need the central files to perform the skimming, unless we want to change the redirector used in the lobster script. Are they just missing on ceph? Let's try to get those copies ASAP.
|
@bryates I think we merge this PR |
anpicci
added a commit
that referenced
this pull request
Dec 20, 2024
…sample, and updated (#449) * Adding json and cfg files. * Run3 processor and event selection * Topeft/modules update * Temporary commit * unit SFs for Run3 * some tweaking * another temp commit * Fixed issues in analysis processor for plain Run3 * Fixed issues in analysis processor for plain Run3 * JME Run3 * Fixing dataset definition for data in analysis_processor * First pkl file version * Adapting SFs to Run3 * Fixing dataset definition for data in analysis_processor * Fixing uncommented line * Stable Run2 + Run3 flow with systematics (when available) * Fixing uncommented line * Fixing uncommented line * Adapting corrections to the new JECStack * Merging with master * Minor fixes * Minor fixes for pylint * Minor fixes for pylint * Minor fixes for pylint * Optimizing JME corrections * fixing pylint errors * Addressing Brent's comments * Fixing pyling comments * Fixing pyling comments * Fixing pyling comments * Implementing Brent's comments * fixing pylint errors * Fixing AttachElectronSF * Updates for plotting with make_cr_and_sr_plots.py * Updated jsons, summed over ext files * Working make_cr_and_sr_plots.py update * Realigning plotter script to Brent's version * Realigning plotter script to Brent's version * Updating redirector * fixing ttbar 2QLNu sample * fixing Run3 cfgs * Script to check that all the files listed in the jsons are reachable * modified files, according to what is present * modified files, according to what is present --------- Co-authored-by: Amanda Ehnis <anehnis@gmail.com>
bryates
added a commit
that referenced
this pull request
Dec 20, 2024
* aligining ch_update to master * first implementation of parsing selections defining a SR - only tried with 2lss_p * Uploading latest Tau SF functions * Update topeft/modules/corrections.py Co-authored-by: Brent R. Yates <brentRyates@gmail.com> * Addressing lint errors * Addressing lint issues * Pin setuptools * Checkout `pin-setuptools` on TopCoffea * Back to topcoffea main * Modifying the code according to the results from the CI tests * adapt datacards_post_processing.py to ch_lst.json * Update ch_lst json * testing * Updates for CRs in processor and json, replacing deepthought with hactar01 * Fixing some bugs in the analysis_processor * fixing channel json * fixing channel json * Updated and working versions * update ch_lst_test.json with 3loffZ split * turn off 3loffZ split * Add tau channels * update datacards_post_processing.py script for ch_lst_test.json * Change tau channels * Add taus to datacards_post_processing * Addressing pylint errors * Addressing pylint errors * Addressing pylint errors * add 3l-offZ-split channels in analysis_processor.py * Addressing Lint errors * Fixing TES/FES * Addressing pylint errors * recalling the correct branch for topcoffea * Changes to tau run mode based on comments * fix run_analysis issue * Generalizing usage of lepton categories for weight_dict * Address pylint issues * Add fwd region * Remove `rebin` * Add `--fwd-flag` and copy LT * Propagate flags correctly * Actually use fwd flag * Update missing parton script * Some improvements * Add `fwd` region to missing parton * Fix lint * Use l1 for `fwd` not `tau` * Ignore specified variables * Revert * Ignore specified variables * edit dc post selection for 2lss_fwd lt * minor update in fwd post dc * update run_analysis for command options * remove 2lss_4t_fwd regions * addressing pylint errors * addressing pylint errors * addressing pylint errors * Addressing Brent's comments and first try to fix CI Analysis errors * addressing pylint errors * Fix CI Analysis errors * fix fwdjet masking * include lt variable in analysis processor * add removed scalings post selection * change back 2lss 4t bin variable to lj0pt * fixing 3l-offZ bug * New jsons for including extensions in the same jsons as the original sample, and updated (#449) * Adding json and cfg files. * Run3 processor and event selection * Topeft/modules update * Temporary commit * unit SFs for Run3 * some tweaking * another temp commit * Fixed issues in analysis processor for plain Run3 * Fixed issues in analysis processor for plain Run3 * JME Run3 * Fixing dataset definition for data in analysis_processor * First pkl file version * Adapting SFs to Run3 * Fixing dataset definition for data in analysis_processor * Fixing uncommented line * Stable Run2 + Run3 flow with systematics (when available) * Fixing uncommented line * Fixing uncommented line * Adapting corrections to the new JECStack * Merging with master * Minor fixes * Minor fixes for pylint * Minor fixes for pylint * Minor fixes for pylint * Optimizing JME corrections * fixing pylint errors * Addressing Brent's comments * Fixing pyling comments * Fixing pyling comments * Fixing pyling comments * Implementing Brent's comments * fixing pylint errors * Fixing AttachElectronSF * Updates for plotting with make_cr_and_sr_plots.py * Updated jsons, summed over ext files * Working make_cr_and_sr_plots.py update * Realigning plotter script to Brent's version * Realigning plotter script to Brent's version * Updating redirector * fixing ttbar 2QLNu sample * fixing Run3 cfgs * Script to check that all the files listed in the jsons are reachable * modified files, according to what is present * modified files, according to what is present --------- Co-authored-by: Amanda Ehnis <anehnis@gmail.com> * reverting some temporary additions * pylint comments addressed --------- Co-authored-by: Andrea Piccinelli <andrea8395@gmail.com> Co-authored-by: Andrea Piccinelli <44297061+anpicci@users.noreply.github.com> Co-authored-by: Brent R. Yates <brentRyates@gmail.com> Co-authored-by: Yuyi Wan <ywan2@glados.crc.nd.edu> Co-authored-by: Brent Yates <yates.313@osu.edu> Co-authored-by: ywan2 <85906153+ywan2@users.noreply.github.com> Co-authored-by: Amanda Ehnis <anehnis@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes updated jsons from @anehnis and updated xsec for the TTToLNu2Q sample