Don't send CAP END before SASL auth is complete

[russss]

The SASL-3.1 spec recommends that CAP END is not sent until SASL auth has completed. The current behaviour is to send CAP END immediately after all requested capabilities have been ACKed or NACKed.

I've found the current behaviour to fail SASL auth intermittently in practice, particularly when additional capabilities are requested. This change is working much more reliably for me.

There's still arguably a race condition in the other direction now - if SASL auth completes before capability negotiation - but I think this is very unlikely to happen in practice.

(Love the library, thanks!)

[linuxdaemon]

Hey, sorry I wasn't maintaining this library for awhile but I'm getting back to it now. The code as it is should wait until sasl auth finishes as the sasl handler is awaited

async-irc/asyncirc/protocol.py

Line 65 in 422d3e7

await asyncio.gather(*[func(conn, cap) for func in handlers])

which will wait until the sasl handler returns before sending cap end. The intermittent behavior may be related to what I just fixed in v0.1.8 where the AUTHENTICATE payload was malformed in some circumstances