Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat: move to a Boxed Adapter #324

Draft
wants to merge 26 commits into
base: main
Choose a base branch
from
Draft

Feat: move to a Boxed Adapter #324

wants to merge 26 commits into from

Conversation

Totodore
Copy link
Owner

@Totodore Totodore commented May 24, 2024

Using a boxed adapter would allow to remove the generic Adapter from every types in the socketioxide codebase.

@Totodore Totodore marked this pull request as draft May 24, 2024 15:40
socketioxide/src/extract/data.rs Fixed Show fixed Hide fixed
socketioxide/src/extract/state.rs Fixed Show fixed Hide fixed
socketioxide/src/socket.rs Fixed Show fixed Hide fixed
socketioxide/src/adapter.rs Fixed Show fixed Hide fixed
socketioxide/src/adapter.rs Fixed Show fixed Hide fixed
socketioxide/src/io.rs Fixed Show fixed Hide fixed
socketioxide/src/ns.rs Fixed Show fixed Hide fixed
socketioxide/src/ns.rs Fixed Show fixed Hide fixed
socketioxide/src/service.rs Fixed Show fixed Hide fixed
Copy link

github-actions bot commented May 24, 2024

🐰Bencher

ReportTue, May 28, 2024 at 14:31:22 UTC
ProjectSocketioxide
Branchft-boxed-adapter
Testbedubuntu-latest

⚠️ WARNING: The following Measure does not have a Threshold. Without a Threshold, no Alerts will ever be generated!

  • Latency (latency)

Click here to create a new Threshold
For more information, see the Threshold documentation.
To only post results if a Threshold exists, set the --ci-only-thresholds CLI flag.

Click to view all benchmark results
BenchmarkLatencyLatency Results
nanoseconds (ns)
engineio_packet/decode/Decode packet binary b64➖ (view plot)85.51
engineio_packet/decode/Decode packet message➖ (view plot)38.44
engineio_packet/decode/Decode packet noop➖ (view plot)33.62
engineio_packet/decode/Decode packet ping/pong➖ (view plot)31.35
engineio_packet/decode/Decode packet ping/pong upgrade➖ (view plot)35.15
engineio_packet/encode/Encode packet binary b64➖ (view plot)55.27
engineio_packet/encode/Encode packet message➖ (view plot)30.71
engineio_packet/encode/Encode packet noop➖ (view plot)30.79
engineio_packet/encode/Encode packet open➖ (view plot)278.25
engineio_packet/encode/Encode packet ping/pong➖ (view plot)29.24
engineio_packet/encode/Encode packet ping/pong upgrade➖ (view plot)30.09
extensions/concurrent_get➖ (view plot)6.85
extensions/concurrent_get_inserts➖ (view plot)14.96
extensions/concurrent_inserts➖ (view plot)20.95
socketio_packet/decode/Decode packet ack on /➖ (view plot)287.30
socketio_packet/decode/Decode packet ack on /custom_nsp➖ (view plot)310.18
socketio_packet/decode/Decode packet binary ack (b64) on /➖ (view plot)515.42
socketio_packet/decode/Decode packet binary ack (b64) on /custom_nsp➖ (view plot)536.40
socketio_packet/decode/Decode packet binary event (b64) on /➖ (view plot)607.32
socketio_packet/decode/Decode packet binary event (b64) on /custom_nsp➖ (view plot)624.91
socketio_packet/decode/Decode packet connect on /➖ (view plot)68.66
socketio_packet/decode/Decode packet connect on /custom_nsp➖ (view plot)79.77
socketio_packet/decode/Decode packet event on /➖ (view plot)356.69
socketio_packet/decode/Decode packet event on /custom_nsp➖ (view plot)385.73
socketio_packet/decode/Decode packet event with ack on /➖ (view plot)357.56
socketio_packet/decode/Decode packet event with ack on /custom_nsp➖ (view plot)386.71
socketio_packet/encode/Encode packet ack on /➖ (view plot)142.39
socketio_packet/encode/Encode packet ack on /custom_nsp➖ (view plot)119.79
socketio_packet/encode/Encode packet binary ack (b64) on /➖ (view plot)308.85
socketio_packet/encode/Encode packet binary ack (b64) on /custom_nsp➖ (view plot)309.81
socketio_packet/encode/Encode packet binary event (b64) on /➖ (view plot)390.53
socketio_packet/encode/Encode packet binary event (b64) on /custom_nsp➖ (view plot)415.05
socketio_packet/encode/Encode packet connect on /➖ (view plot)52.94
socketio_packet/encode/Encode packet connect on /custom_nsp➖ (view plot)56.47
socketio_packet/encode/Encode packet event on /➖ (view plot)118.59
socketio_packet/encode/Encode packet event on /custom_nsp➖ (view plot)123.96
socketio_packet/encode/Encode packet event with ack on /➖ (view plot)117.96
socketio_packet/encode/Encode packet event with ack on /custom_nsp➖ (view plot)123.33

Bencher - Continuous Benchmarking
View Public Perf Page
Docs | Repo | Chat | Help

@Totodore Totodore added the enhancement New feature or request label May 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant