Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: switch from poetry to uv #2324

Merged
merged 2 commits into from
Jan 17, 2025
Merged

feat: switch from poetry to uv #2324

merged 2 commits into from
Jan 17, 2025

Conversation

lukapeschke
Copy link
Contributor

No description provided.

@lukapeschke lukapeschke force-pushed the switch-to-uv branch 2 times, most recently from 24c1e68 to 622dff2 Compare January 17, 2025 14:41
@lukapeschke
feat: switch from poetry to uv
8b8719c 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke marked this pull request as ready for review January 17, 2025 15:07
@lukapeschke lukapeschke requested a review from a team as a code owner January 17, 2025 15:07
@lukapeschke lukapeschke requested review from Fanaen and julien-pinchelimouroux and removed request for a team January 17, 2025 15:07
@lukapeschke lukapeschke self-assigned this Jan 17, 2025
julien-pinchelimouroux
julien-pinchelimouroux approved these changes Jan 17, 2025
View reviewed changes
Copy link
Contributor

@julien-pinchelimouroux julien-pinchelimouroux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Des paquets n'ont pas la meme version
On se base sur les TU pour valider ? Au pire ca cassera les guru je me dis

.github/workflows/ci-server.yml Outdated
run: |
pip install poetry
poetry config virtualenvs.create false
curl -LsSf https://astral.sh/uv/0.5.20/install.sh | sh
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on peut tag vers un latest ? ou sinon mettre la version UV en variable histoire que ce soit un peu plus lisible

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

On peut mais je préférais éviter les breaking changes. mais bonne idée pour la variable

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

69e98f1

@lukapeschke
Copy link
Contributor Author

Des paquets n'ont pas la meme version
On se base sur les TU pour valider ? Au pire ca cassera les guru je me dis

Attention à ne pas confondre lockfile et contraintes: le lockfile ne concerne QUE le repo actuel (et les tests sont verts donc on est bons). Les repos qui utilisent cette lib résolvent leur propre version en fonction des contraintes définies dans le pyproject.toml, qui lui a gardé les mêmes contraintes. Par exemple, attrs était en 23.1.0 dans ce lockfile-ci, mais en 24.2.0 dans laputa

@lukapeschke
refactor: uv version as env var
69e98f1 
Signed-off-by: Luka Peschke <luka.peschke@toucantoco.com>
@lukapeschke lukapeschke merged commit 49014f8 into master Jan 17, 2025
3 checks passed
@lukapeschke lukapeschke deleted the switch-to-uv branch January 17, 2025 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@julien-pinchelimouroux julien-pinchelimouroux julien-pinchelimouroux approved these changes

@Fanaen Fanaen Fanaen approved these changes

Assignees

@lukapeschke lukapeschke

Labels
build enhancement New feature or request need review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukapeschke @Fanaen @julien-pinchelimouroux