Skip to content

Commit

Permalink
Merge pull request #25 from Toumash/pr/simplify-images
Browse files Browse the repository at this point in the history
feat: simplify images and e2e test so that we know if it works
  • Loading branch information
Toumash authored Nov 5, 2023
2 parents 2898427 + e9030c8 commit 120d814
Show file tree
Hide file tree
Showing 5 changed files with 51 additions and 14 deletions.
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@

1. Configure your client-side

For running mlflow files you need various environment variables set on the client side. To generate them user the convienience script `./bashrc_install.sh`, which installs it on your system or `./bashrc_generate.sh`, which just displays the config to copy & paste.
For running mlflow files you need various environment variables set on the client side. To generate them use the convienience script `./bashrc_install.sh`, which installs it on your system or `./bashrc_generate.sh`, which just displays the config to copy & paste.

> $ ./bashrc_install.sh
> [ OK ] Successfully installed environment variables into your .bashrc!
Expand Down
24 changes: 20 additions & 4 deletions docker-compose.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,12 +31,9 @@ services:
networks:
- internal
mlflow:
image: ubuntu/mlflow:2.1.1_1.0-22.04
container_name: tracker_mlflow
image: tracker_ml
restart: unless-stopped
build:
context: ./mlflow
dockerfile: Dockerfile
ports:
- "5000:5000"
environment:
Expand Down Expand Up @@ -70,6 +67,25 @@ services:
command: tcp db:3306 -t 90s -i 250ms
networks:
- internal
run_test_experiment:
build:
context: ./test_experiment
dockerfile: Dockerfile
depends_on:
- "mlflow"
environment:
- AWS_ACCESS_KEY_ID=${AWS_ACCESS_KEY_ID}
- AWS_SECRET_ACCESS_KEY=${AWS_SECRET_ACCESS_KEY}
- AWS_DEFAULT_REGION=${AWS_REGION}
- MLFLOW_S3_ENDPOINT_URL=http://s3:9000
- MLFLOW_TRACKING_URI=http://mlflow:5000
entrypoint: >
/bin/sh -c "
python3 mlflow_tracking.py;
exit 0;
"
networks:
- internal
networks:
internal:
public:
Expand Down
12 changes: 6 additions & 6 deletions quickstart/mlflow_tracking.py
Original file line number Diff line number Diff line change
@@ -1,22 +1,22 @@
import os
from random import random, randint

from mlflow import mlflow,log_metric, log_param, log_artifacts
import mlflow

if __name__ == "__main__":
with mlflow.start_run() as run:
mlflow.set_tracking_uri('http://localhost:5000')
print("Running mlflow_tracking.py")

log_param("param1", randint(0, 100))
mlflow.log_param("param1", randint(0, 100))

log_metric("foo", random())
log_metric("foo", random() + 1)
log_metric("foo", random() + 2)
mlflow.log_metric("foo", random())
mlflow.log_metric("foo", random() + 1)
mlflow.log_metric("foo", random() + 2)

if not os.path.exists("outputs"):
os.makedirs("outputs")
with open("outputs/test.txt", "w") as f:
f.write("hello world!")

log_artifacts("outputs")
mlflow.log_artifacts("outputs")
5 changes: 2 additions & 3 deletions mlflow/Dockerfile → test_experiment/Dockerfile
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
FROM continuumio/miniconda3:latest

RUN pip install mlflow boto3 pymysql
RUN pip install mlflow boto3

ADD . /app
WORKDIR /app

COPY . .
22 changes: 22 additions & 0 deletions test_experiment/mlflow_tracking.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
import os
from random import random, randint

import mlflow

if __name__ == "__main__":
with mlflow.start_run() as run:
mlflow.set_tracking_uri('http://mlflow:5000')
print("Running mlflow_tracking.py")

mlflow.log_param("param1", randint(0, 100))

mlflow.log_metric("foo", random())
mlflow.log_metric("foo", random() + 1)
mlflow.log_metric("foo", random() + 2)

if not os.path.exists("outputs"):
os.makedirs("outputs")
with open("outputs/test.txt", "w") as f:
f.write("hello world!")

mlflow.log_artifacts("outputs")

0 comments on commit 120d814

Please sign in to comment.