Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: include array to use std::array #3

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: include array to use std::array #3

wants to merge 2 commits into from

Conversation

aminya
Copy link

@aminya aminya commented Aug 8, 2022 •
edited
Loading

This fixes an error on C++ 20

@aminya
Copy link
Author

aminya commented Aug 29, 2022

@frankpermenter Could you take a look at this?

@jwnimmer-tri
Copy link

I have the same problem.

One thing to note about the patch: we keep #include alpha-sorted, so <array> should precede the other standard library includes.

@jwnimmer-tri jwnimmer-tri mentioned this pull request Jan 5, 2023
Merged
aminya
aminya commented Jan 9, 2023
View reviewed changes
conex/debug_macros.h Outdated Show resolved Hide resolved
conex/tree_utils.cc Outdated Show resolved Hide resolved
@aminya
Copy link
Author

aminya commented Jan 9, 2023 •
edited
Loading

One thing to note about the patch: we keep #include alpha-sorted, so <array> should precede the other standard library includes.

Fixed in e439838

@jwnimmer-tri jwnimmer-tri mentioned this pull request Jan 30, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aminya @jwnimmer-tri