Skip to content

Commit

Permalink
Allow VERSION to have a newline (makes releasing easier)
Browse files Browse the repository at this point in the history
  • Loading branch information
sudara committed Dec 3, 2024
1 parent 1afc111 commit abec715
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ jobs:
- name: Setup Environment Variables
shell: bash
run: |
VERSION=$(cat VERSION)
VERSION=$(head -n1 VERSION)
echo "VERSION=$VERSION" >> $GITHUB_ENV
echo "APP_DIR=${{ env.BUILD_DIR }}/${{ env.BINARY_NAME }}_artefacts/${{ env.BUILD_TYPE }}" >> $GITHUB_ENV
echo "ZIP_FILE_NAME=${{ env.BINARY_NAME }}_${{ matrix.name }}.zip" >> $GITHUB_ENV
Expand Down
2 changes: 1 addition & 1 deletion CMakeLists.txt
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
cmake_minimum_required(VERSION 3.15)

file(READ VERSION CURRENT_VERSION)
file(STRINGS VERSION CURRENT_VERSION LIMIT_COUNT 1)
project(pluginval VERSION ${CURRENT_VERSION})

if (APPLE)
Expand Down
2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ If you have a case you would like tests, please simply write the test in a fork
### Cutting New Releases
* Update VERSION (make sure there's not an extra newline)
* Update VERSION (an extra newline is fine)
* Update CHANGELIST.md
* `git commit -am "Version 1.0.5"`
* `git tag -a v1.0.5 -m "1.0.5 release"`
Expand Down

0 comments on commit abec715

Please sign in to comment.