chore: improve README #254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- adds missing `borderColor` description - improves `trapezoid` and `hexagon` shape descrptions - removes deprecated Go-Ahead Bayern example - adds new Alex DLB example with both `borderColor` and `wikidataQid` set - adds new Hadag trapezoid shape sample - adds new Hamburger Hochbahn hexagon shape sample - removes deprecated "Other shapes" section Signed-off-by: The one with the braid <info@braid.business>
MrKrisKrisu
approved these changes
Dec 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I figured out the
Structuresection of the README was missing theborderColorcolumn, moreover a description of thehexagonandtrapezoidsection. Additionally, we were lacking an example withborderColorset. I replaced the first example (since the corresponding entry does no longer exist) with a new example of one of the few lines with both aborderColorand awikidataQidset ; in this case the ALEX RE 23.I moreover added detailed samples of the
hexagonandtrapezoidshapes rather than the comment "Other shapes".borderColordescriptiontrapezoidandhexagonshape descrptionsborderColorandwikidataQidsetRelated: #253 and Traewelldroid/traewelldroid#465