✅ add hex-color validator and add unit tests for the validation rules #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For this, some validation functions are extracted out to common.php and unit test cases are described.
jeyemwey
force-pushed
the
jv-validator2
branch
from
63f20d1 to
3768562
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a validation rule for the color fields which should always be 6-digit hex codes with a # in front (inspired by #40). Turns out there were even more cases where that wasn't set properly!
Since the validation rules are getting more and more complex, I've added a very barebones unit test framework which can cross-check if the rules are doing what we want them to. This turned out to be the larger part of this PR.
Hope it's alright for y'all and hopefully this can add to a better data quality overall.