Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Westfrankenbahn regional trains #50

Merged
merged 6 commits into from
Oct 24, 2023
Merged

Added Westfrankenbahn regional trains #50

merged 6 commits into from
Oct 24, 2023

Conversation

oneiricbotcelot
Copy link
Contributor

oneiricbotcelot and others added 4 commits October 14, 2023 09:56
@oneiricbotcelot
Update line-colors.csv
1d8e449 
Added 6 lines of westfrankenbahn
@oneiricbotcelot
Update sources.json
7696f51 
Added map of westfrankenbahn
@oneiricbotcelot
Update sources.json
87e6066 
Removed blank line
@jeyemwey
Reorder
849d5bc
oneiricbotcelot
oneiricbotcelot commented Oct 22, 2023
View reviewed changes
Copy link
Contributor Author

@oneiricbotcelot oneiricbotcelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The reordering seems wrong to me: line names starting with RB should always be listed before RE.

@MrKrisKrisu
Copy link
Member

The reordering seems wrong to me: line names starting with RB should always be listed before RE.

@jeyemwey Kannst du mal schauen? Das sieht wirklich komisch aus. B < E

@jeyemwey
Copy link
Contributor

Jup, super großes sorry, da war ich ein wenig blind. Bitte reverted und dann schnell vergessen c:

@jeyemwey
Copy link
Contributor

So. Bitte nochmal drueber schauen und dann koennen wa auch

oneiricbotcelot
oneiricbotcelot commented Oct 24, 2023
View reviewed changes
Copy link
Contributor Author

@oneiricbotcelot oneiricbotcelot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me! :)

@MrKrisKrisu MrKrisKrisu merged commit a88cf88 into Traewelling:main Oct 24, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MrKrisKrisu MrKrisKrisu MrKrisKrisu approved these changes

@jeyemwey jeyemwey jeyemwey approved these changes

Assignees

@jeyemwey jeyemwey

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@oneiricbotcelot @MrKrisKrisu @jeyemwey