Make the vc logs consistent by removing Nickname from embed description #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove Nickname from embed description, to match voiceChannelJoin (nick is still in embed title so no difference)
Remove Nickname from embed description, to match voiceChannelJoin (nick is still in embed title so no difference)
Minion3665
approved these changes
Oct 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The voiceChannelJoin event embed description contains the user's name, "joined", then the voice channel they joined. The other two channels also had the user's nickname after the user's name. Since their nickname is also in the embed title, it's redundant and I decided to remove it for consistency reasons.