Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for additional pythia-160m seeds #337

Closed
wants to merge 0 commits into from

Conversation

will-hath
Copy link
Contributor

Description

Added support for loading in models pythia-160m-seed1, pythia-160m-seed2, pythia-160m-seed3 with HookedTransformers, as well as a test to confirm that all official model names exist. Added specs to documentation as well.

Type of change

Please delete options that are not relevant.

  • support for new pythia seeds

Checklist:

  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have not rewritten tests relating to key interfaces which would affect backward compatibility

@jbloomAus
Copy link
Collaborator

@will-hath model_properties_table.md is generated automatically, did you manually edit it and is this why we have a merge conflict? It's possible this isn't the case in which case possible you just need to rebase to solve it.

Other than merge conflict, seems good. Thanks!

@jbloomAus jbloomAus added the seen_by_maintainers Confirms that a maintainer is aware of this card. label Jul 26, 2023
@will-hath will-hath closed this Jul 27, 2023
@will-hath will-hath force-pushed the main branch 2 times, most recently from 66d3233 to bf5ed27 Compare July 27, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
seen_by_maintainers Confirms that a maintainer is aware of this card.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants