-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add functionality pause and resume for consumer #89
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## v2 #89 +/- ##
==========================================
+ Coverage 35.62% 37.07% +1.45%
==========================================
Files 19 19
Lines 685 712 +27
==========================================
+ Hits 244 264 +20
- Misses 434 441 +7
Partials 7 7 ☔ View full report in Codecov by Sentry. |
Abdulsametileri
commented
Jan 13, 2024
Abdulsametileri
commented
Jan 14, 2024
mhmtszr
approved these changes
Jan 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on this issue and some internal projects, I implemented a
pause/resume
consuming mechanism.Before implementation, I researched segmentio/kafka-go issues for this functionality. I came across this issue. achille-roussel answer is really clear. If I stop calling
FetchMessage,
the consumer pauses. If I invokeFetchMessage,
it resumes. Consumer group is still Stable because when I calledkafka.NewConsumer
, segmentio creates a goroutine and starts heartbeat to the broker under the hood!First, I defined two methods,
Resume
andPause
on the Consumer interface. So our clients can invoke this easily. You can refer to examples/with-pause-resume-consumer/main.go. It basicallyI also added related documentation within the example.