Add error handling for version history file loading #7983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew2a
force-pushed
the
fix/7920
branch
3 times, most recently
from
9575b8f to
42e7187
Compare
xoriole
approved these changes
Apr 21, 2024
Introduced exception handling to manage potential errors during the loading of the version history file. If a VersionError is encountered, it logs a warning and attempts to remove the corrupted version file. In case of an OSError during this removal process, another warning is logged. Additionally, JSONDecodeError is now caught when attempting to load JSON from the file content, raising a VersionError if such an issue occurs. This improves robustness against corrupted or improperly formatted version history files.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduced exception handling to manage potential errors during the loading of the version history file. If a VersionError is encountered, it logs a warning and attempts to remove the corrupted version file. In case of an OSError during this removal process, another warning is logged. Additionally, JSONDecodeError is now caught when attempting to load JSON from the file content, raising a VersionError if such an issue occurs. This improves robustness against corrupted or improperly formatted version history files.
Fixes #7920