Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

READY: Consolidate error responses #8264

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

qstokkink
Copy link
Contributor

@qstokkink qstokkink commented Nov 14, 2024

Fixes #8263

This PR:

  • Updates all instances of error RESTResponses to conform to {error: {handled: bool, message: string}}.

Notes:

  • In rest_endpoint.py I do prefix the exception class because it is lost after the str() conversion. In rest_manager.py I don't prefix the exception class because it is already part of the traceback.

@qstokkink qstokkink force-pushed the upd_rest_error_responses branch 2 times, most recently from 03f1b45 to be3e0c0 Compare November 14, 2024 13:05
@qstokkink qstokkink force-pushed the upd_rest_error_responses branch from be3e0c0 to 67750fd Compare November 14, 2024 13:07
@qstokkink qstokkink marked this pull request as ready for review November 14, 2024 13:11
@qstokkink qstokkink changed the title WIP: Consolidate error responses READY: Consolidate error responses Nov 14, 2024
@qstokkink qstokkink merged commit 6fb9bb1 into Tribler:main Nov 14, 2024
7 checks passed
@qstokkink qstokkink deleted the upd_rest_error_responses branch November 14, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate REST error responses
2 participants