fix: left join 시 중복 문제 해결 -> 일부 서브 쿼리로 해결 #184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Astin01
reviewed
Sep 19, 2024
| @@ -51,14 +51,11 @@ public GatheringRepositoryImpl() { | |||
|
|
|||
| @Override | |||
| public List<GatheringBriefResponse> getGatheringRecommend(Long gatheringId, Long gatheringCategoryId, Long userId) { | |||
|
|
|||
| NumberExpression<Integer> likeCount = countGreatGatheringByGatheringById(); | |||
| NumberExpression<Integer> applicantsCount = applicantsCountNowConsent(); | |||
| return from(gathering) | |||
| .join(zoneCategoryChild).on(zoneCategoryChild.id.eq(gathering.zoneCategory.id)) | |||
| .leftJoin(zoneCategoryParent).on(zoneCategoryParent.id.eq(zoneCategoryChild.parentZoneCategory.id)) | |||
There was a problem hiding this comment.
아직 join시에 fetch join 적용이 안되어 있는데 이부분은 추후에 수정해주시면 좋을 거 같습니다
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝작업 내용
gathering 추천 리스트, gathering 페이지네이션, gathering_home 쿼리문 수정
gathering applicants 수 leftjoin -> 서브쿼리로 변경
gathering like count 서브쿼리로 변경
해당 회원이 좋아요 했는지 서브쿼리로 변경
해당 회원이 북마크 했는지 서브쿼리로 변경
home_gathering에서 좋아요 했는지, 북마크 했는지 데이터 확인