-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: split feature powerset job per crate #192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eopb
force-pushed
the
push-nxmxtooxtsuy
branch
from
October 17, 2024 08:18
cc9ea2d
to
ec494fc
Compare
eopb
force-pushed
the
push-nxmxtooxtsuy
branch
2 times, most recently
from
October 17, 2024 08:30
34af4c1
to
1d6d7e0
Compare
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
eopb
force-pushed
the
push-nxmxtooxtsuy
branch
from
October 17, 2024 08:53
1d6d7e0
to
ee58c4c
Compare
Comment on lines
+64
to
+69
- name: Install Rust | ||
uses: actions-rs/toolchain@v1 | ||
with: | ||
toolchain: stable | ||
profile: minimal | ||
override: true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is deprecated;
Suggested change
- name: Install Rust | |
uses: actions-rs/toolchain@v1 | |
with: | |
toolchain: stable | |
profile: minimal | |
override: true | |
- name: Install Rust | |
uses: dtolnay/rust-toolchain@stable | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see. Let's fix this in a follow up PR
tl-eirik-albrigtsen
approved these changes
Oct 17, 2024
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
Thanks for the suggestion @tl-eirik-albrigtsen this is deprecated; ```suggestion - name: Install Rust uses: dtolnay/rust-toolchain@stable ``` _Originally posted by @tl-eirik-albrigtsen in #192 (comment)
eopb
added a commit
that referenced
this pull request
Oct 17, 2024
Thanks for the suggestion @tl-eirik-albrigtsen this is deprecated; ```suggestion - name: Install Rust uses: dtolnay/rust-toolchain@stable ``` _Originally posted by @tl-eirik-albrigtsen in #192 (comment)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188