Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: split feature powerset job per crate #192

Merged
merged 1 commit into from
Oct 17, 2024
Merged

ci: split feature powerset job per crate #192

merged 1 commit into from
Oct 17, 2024

Conversation

eopb
Copy link
Member

@eopb eopb commented Oct 17, 2024

The current job takes too long and fails due to the exponential growth caused by new features introduced in #188

@eopb eopb changed the base branch from push-xtlqowxrvpym to main October 17, 2024 08:18
@eopb eopb force-pushed the push-nxmxtooxtsuy branch 2 times, most recently from 34af4c1 to 1d6d7e0 Compare October 17, 2024 08:30
The current job takes too long and fails due to the exponential growth caused by new features introduced in #188
@eopb eopb marked this pull request as ready for review October 17, 2024 08:53
@eopb eopb requested a review from a team as a code owner October 17, 2024 08:53
Comment on lines +64 to +69
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is deprecated;

Suggested change
- name: Install Rust
uses: actions-rs/toolchain@v1
with:
toolchain: stable
profile: minimal
override: true
- name: Install Rust
uses: dtolnay/rust-toolchain@stable

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see. Let's fix this in a follow up PR

@eopb eopb enabled auto-merge (squash) October 17, 2024 10:31
@eopb eopb disabled auto-merge October 17, 2024 10:31
@eopb eopb merged commit b8069e2 into main Oct 17, 2024
11 checks passed
@eopb eopb deleted the push-nxmxtooxtsuy branch October 17, 2024 10:31
eopb added a commit that referenced this pull request Oct 17, 2024
Thanks for the suggestion @tl-eirik-albrigtsen

              this is deprecated;
```suggestion
      - name: Install Rust
        uses: dtolnay/rust-toolchain@stable

```

_Originally posted by @tl-eirik-albrigtsen in #192 (comment)
eopb added a commit that referenced this pull request Oct 17, 2024
Thanks for the suggestion @tl-eirik-albrigtsen

              this is deprecated;
```suggestion
      - name: Install Rust
        uses: dtolnay/rust-toolchain@stable

```

_Originally posted by @tl-eirik-albrigtsen in #192 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants