Update BaseStorage.js #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Combined the logic for constructing the filename in generateUnique. Simplified the extension check in getUniqueFileName. Used default parameter for i and simplified the recursion logic. Used const and let, template literals, and async/await for better readability and performance.
Update moment dependency and nodeJS version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Combined the logic for constructing the filename in generateUnique. Simplified the extension check in getUniqueFileName. Used default parameter for i and simplified the recursion logic. Used const and let, template literals, and async/await for better readability and performance. Also update moment and nodejs version dependencies