Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

i18n: add missing Arabic translation file #21651

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

KHAWARIZMIX
Copy link

  • Translated all keys in the following language JSON files to Arabic: Ghost, Portal, Search, Signup- Form, and Comments.
  • Ensured consistency and accuracy for improved user experience
  • Verified language integration and formatting for consistency

This commit provides the Arabic translation for all relevant UI components in Ghost CMS, filling a previously missing language option.

Got some code for us? Awesome 🎊!

Please include a description of your change & check your PR against this list, thanks!

  • There's a clear use-case for this code change, explained below
  • Commit message has a short title & references relevant issues
  • The build will pass (run yarn test:all and yarn lint)

We appreciate your contribution!

- Translated all keys in the following language JSON files to Arabic: Ghost, Portal, Search, Signup-	Form, and Comments.
- Ensured consistency and accuracy for improved user experience 
- Verified language integration and formatting for consistency

This commit provides the Arabic translation for all relevant UI components in Ghost CMS, filling a previously missing language option.
"Head of Marketing at Acme, Inc": "رئيس التسويق في شركة أكمي",
"Hide": "إخفاء",
"Hide comment": "إخفاء التعليق",
"Jamie Larson": "جيمي لارسون",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the original translation for "Jamie Larson" is better, as it is intended to be a generic name, not a literal transliteration.

@cathysarisky
Copy link
Contributor

Hello, and thank you for this submission. Although your post says you're adding a missing file, these appear to all be changes to existing translations. @mostafty and @almrx and @KSAART , I would be grateful if you would review these translations and reach consensus on what the best wording is.

@mostafty
Copy link
Contributor

Okay, I deserve that. My translation is generally better but like most Arabs I didn't distinguish between أ إ and ا. I instead used ا in all cases. he got that right and better.

Other than that this version has some mistakes that will end up looking laughable like using singular instead of plural. some translation ignore the cultural context.

My educated guess is that this was a machine translation and that explain the correct grammar while ignoring the context.

I'm not very good with Git but if someone guides me I can merge both and give you the best of both worlds. @cathysarisky , can you help me here? should I do another pull request after merging both in my local repo. or what's the best way to resolve the conflict?

@cathysarisky
Copy link
Contributor

Let's see if @KHAWARIZMIX responds. If K's unresponsive, you could certainly put in a new PR and this one could be closed without merging. But perhaps K will respond (and we should give them a couple days as a courtesy) and you can collaborate. :)

@KHAWARIZMIX
Copy link
Author

Hello, thank you for your kind response!
To be honest, I had already pushed my translation to the repository a few days ago, as I noticed there wasn’t a complete Arabic translation available at the time. However, since it was my first time contributing, I forgot to create a pull request until today.

I deeply appreciate the efforts of all contributors, especially the Arabic translators. I didn’t attempt to merge my translation because I thought it was better than anyone else’s work, but simply because I wasn’t aware that others were already contributing.

I’m not here to compete or challenge others. My goal is to offer my help to the community that I admire and want to support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants