Bijector for product distribution #304
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
return the identity whenever possible
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…stribution' into torfjelde/ordered-for-product-distribution
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…stribution' into torfjelde/ordered-for-product-distribution
`Distributions.ProductDistribution` and similars
|
Might be worth for you to have a look at this one @devmotion if you have the time, given that it's related to |
|
@yebai or @devmotion wanna have a quick look at this? |
yebai
approved these changes
May 7, 2024
There was a problem hiding this comment.
Thanks @torfjelde -- it looks good overall. Maybe consider adding some dos strings and a simple test?
|
Ah yes, sorry; seems I completely forgot to include the tests! Will do EDIT: Had just forgotten to commit them. |
|
Will merge at the end of the day here too unless I receive objections, e.g. @devmotion has thoughts on it |
|
@torfjelde tests for https://github.com/TuringLang/Bijectors.jl/actions/runs/9000497684/job/24724777705 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at implementing a bijector for arbitrary product distributions.
Note that this is very much a draft.
fix #300