Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Work around eachslice limitation on Julia <v1.9 #323

Merged
merged 3 commits into from
Aug 13, 2024

Conversation

mhauru
Copy link
Member

@mhauru mhauru commented Aug 12, 2024

No description provided.

@mhauru
Copy link
Member Author

mhauru commented Aug 13, 2024

The (unrelated) test_rrule! stuff still fails, but the inference tests seem to be fixed by this.

@mhauru
Copy link
Member Author

mhauru commented Aug 13, 2024

The test_rrule!! stuff was just a matter of Tapir.jl having changed an interface.

@yebai yebai merged commit 328a7ea into torfjelde/product-fix Aug 13, 2024
26 checks passed
@yebai yebai deleted the mhauru/product-fix branch August 13, 2024 21:26
@torfjelde
Copy link
Member

Awesome stuff @mhauru :)

mhauru added a commit that referenced this pull request Aug 14, 2024
* Added default impl of `_logabdetjac_dist` so we can support non-batch
by default

* Added test for product of `Dirichlet`

* Bump patch version

* Update src/Bijectors.jl

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>

* Work around eachslice limitation on Julia <v1.9 (#323)

* Work around eachslice limitation on Julia <v1.9

* Bug fix

* Fix Tapir tests

* Apply suggestions from code review

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

* Update test/ad/chainrules.jl

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>

---------

Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: Markus Hauru <markus@mhauru.org>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Co-authored-by: Hong Ge <3279477+yebai@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants