Skip to content

Commit

Permalink
Fix up config handling
Browse files Browse the repository at this point in the history
  • Loading branch information
lmcinnes committed Nov 12, 2024
1 parent a8eaf2e commit f1245ab
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 5 deletions.
6 changes: 3 additions & 3 deletions datamapplot/create_plots.py
Original file line number Diff line number Diff line change
Expand Up @@ -477,11 +477,11 @@ def create_interactive_plot(
config = ConfigManager()

for param_name, param_value in function_signature.parameters.items():
if param_name in ("data_map_coords", "label_layers"):
if param_name in ("data_map_coords", "label_layers", "hover_text"):
continue

provided_value = function_args.get(param_name)
if provided_value == param_value.default:
if provided_value is param_value.default:
if param_name in config:
function_args[param_name] = config[param_name]

Expand Down
2 changes: 1 addition & 1 deletion datamapplot/interactive_rendering.py
Original file line number Diff line number Diff line change
Expand Up @@ -723,7 +723,7 @@ def render_html(
continue

provided_value = function_args.get(param_name)
if provided_value == param_value.default:
if provided_value is param_value.default:
if param_name in config:
function_args[param_name] = config[param_name]

Expand Down
2 changes: 1 addition & 1 deletion datamapplot/plot_rendering.py
Original file line number Diff line number Diff line change
Expand Up @@ -467,7 +467,7 @@ def render_plot(
continue

provided_value = function_args.get(param_name)
if provided_value == param_value.default:
if provided_value is param_value.default:
if param_name in config:
function_args[param_name] = config[param_name]

Expand Down

0 comments on commit f1245ab

Please sign in to comment.