SharedFlow.subscribe() collects only when lifecycle is STARTED

Tweener · Nov 25, 2024 · f68f903 · f68f903
1 parent dbd02e1
commit f68f903
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 6 deletions.
diff --git a/czan/build.gradle.kts b/czan/build.gradle.kts
@@ -107,6 +107,7 @@ kotlin {
             implementation(compose.runtime)
             implementation(compose.components.resources)
             implementation(libs.compose.multiplatform.material3)
+            implementation(libs.compose.multiplatform.lifecycle)
 
             // Coil (Image fetcher)
             implementation(libs.bundles.coil)
@@ -120,7 +121,6 @@ kotlin {
             api(compose.preview)
             api(compose.uiTooling)
             implementation(libs.android.activity.compose)
-            implementation(libs.android.lifecycle.compose)
 
             // Image fetcher
             implementation(libs.ktor.client.android) // HTTPClient to use with Coil to fetch images

diff --git a/czan/src/commonMain/kotlin/com/tweener/czan/_internal/kotlinextensions/FlowExtensions.kt b/czan/src/commonMain/kotlin/com/tweener/czan/_internal/kotlinextensions/FlowExtensions.kt
@@ -2,6 +2,9 @@ package com.tweener.czan._internal.kotlinextensions
 
 import androidx.compose.runtime.Composable
 import androidx.compose.runtime.LaunchedEffect
+import androidx.lifecycle.Lifecycle
+import androidx.lifecycle.compose.LocalLifecycleOwner
+import androidx.lifecycle.repeatOnLifecycle
 import kotlinx.coroutines.flow.SharedFlow
 
 /**
@@ -11,9 +14,11 @@ import kotlinx.coroutines.flow.SharedFlow
 
 @Composable
 inline fun <T> SharedFlow<T>.subscribe(crossinline action: (T) -> Unit) {
-    with(this) {
-        LaunchedEffect(this) {
-            this@with.collect { action(it) }
+    val lifecycleOwner = LocalLifecycleOwner.current
+
+    LaunchedEffect(this) {
+        lifecycleOwner.repeatOnLifecycle(state = Lifecycle.State.STARTED) {
+            this@subscribe.collect { action(it) }
         }
     }
 }
diff --git a/gradle/libs.versions.toml b/gradle/libs.versions.toml
@@ -9,19 +9,20 @@ shimmer = "1.3.0"
 cupertinoCompose = "0.1.0-alpha04"
 ktor = "3.0.1"
 coil = "3.0.2"
+composeLifecycle = "2.8.4"
 
 # Tweener
 tweenerBom = "2.1.1"
 
 # Android
 androidDesugarJdkLibs = "2.1.3"
 androidActivityCompose = "1.9.3"
-androidLifecycleCompose = "2.8.7"
 
 [libraries]
 shimmer = { group = "com.valentinilk.shimmer", name = "compose-shimmer", version.ref = "shimmer" }
 cupertino-compose = { group = "io.github.alexzhirkevich", name = "cupertino-adaptive", version.ref = "cupertinoCompose" }
 compose-multiplatform-material3 = { group = "org.jetbrains.compose.material3", name = "material3", version.ref = "composeMultiplatform" }
+compose-multiplatform-lifecycle = { group = "org.jetbrains.androidx.lifecycle", name = "lifecycle-runtime-compose", version.ref = "composeLifecycle" }
 
 # Tweener
 tweener-bom = { group = "io.github.tweener", name = "kmp-bom", version.ref = "tweenerBom" }
@@ -38,7 +39,6 @@ ktor-client-ios = { group = "io.ktor", name = "ktor-client-ios", version.ref = "
 # Android
 android-desugarjdklibs = { group = "com.android.tools", name = "desugar_jdk_libs", version.ref = "androidDesugarJdkLibs" }
 android-activity-compose = { group = "androidx.activity", name = "activity-compose", version.ref = "androidActivityCompose" }
-android-lifecycle-compose = { group = "androidx.lifecycle", name = "lifecycle-runtime-compose", version.ref = "androidLifecycleCompose" }
 
 [bundles]
 coil = ["coil-compose", "coil-network-ktor"]