feat: allow broader storage configuration #25
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #12
Motivations
Discussed in #12
Modifications
This PR changes the structure of the
server.storage
block and is therefore a breaking change.This takes the existing storage config (below for reference):
and modifies it to the following, basically moving it under
main
.Then we have the
backups
key, which supports any Kubernetes Volume spec as it's body. ThepersistentVolumeClaim
is a special case which matches the schema ofserver.storage.main
rather than the Kubernetes Volume specFinally, we have the
extra
array. This takes a list of objects wherename
andmountPath
are required, along with a Kubernetes volume spec. Inextra
, thesubPath
andreadOnly
of the volume mounts on the deployment are configurable. If apersistentVolumeClaim
is used,external
can be set to not provision a new PVC, otherwisesize
,storageClassName
, andpreventDelete
can be used to modify the provisioned PVC. Thevalues.yaml
shows several commented examples of this:palworld-server-chart/charts/palworld/values.yaml
Lines 45 to 94 in 5fae741