Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add s390x support for pump #704

Closed
wants to merge 4 commits into from
Closed

Conversation

sweep-ai[bot]
Copy link

@sweep-ai sweep-ai bot commented Aug 7, 2023

Description

This PR adds support for building pump assets for the s390x architecture. It includes modifications to the Dockerfile and the .goreleaser.yml file to enable building for the s390x architecture.

Summary of Changes

  • Modified ci/Dockerfile.std to add a new build stage for the s390x architecture. This includes updating the base image to the s390x version, copying necessary files, and running build commands.
  • Modified ci/goreleaser/goreleaser.yml to add a new build configuration for the s390x architecture. This includes adding a new item in the builds array with the s390x GOARCH value.

Please review and merge this PR to enable building pump assets for the s390x architecture.

Fixes #699.


To checkout this PR branch, run the following command in your terminal:

git checkout sweep/add-s390x-support_2

To get Sweep to edit this pull request, leave a comment below or in the code. Leaving a comment in the code will only modify the file but commenting below can change the entire PR.

@sweep-ai sweep-ai bot requested a review from a team as a code owner August 7, 2023 16:03
@sweep-ai sweep-ai bot added the sweep Assigns Sweep to an issue or pull request. label Aug 7, 2023
@sweep-ai
Copy link
Author

sweep-ai bot commented Aug 8, 2023

GitHub actions yielded the following error.

The command that failed is /__t/goreleaser-action/1.19.2/x64/goreleaser. Here are the relevant lines from the logs:

�[1;94m  •�[0m �[1mstarting release...�[0m
�[1;94m  •�[0m loading config file                              �[1;94mfile�[0m=ci/goreleaser/goreleaser.yml
�[1;94m  •�[0m �[1mloading environment variables�[0m
�[1;94m    •�[0m using token from "$GITHUB_TOKEN"
�[1;94m  •�[0m �[1mgetting and validating git state�[0m
�[1;93m    •�[0m ignoring errors because this is a snapshot     �[1;93merror�[0m=git doesn't contain any tags. Either add a tag or use --snapshot
�[1;94m    •�[0m building...                                    �[1;94mcommit�[0m=98e80ed754873b3d19e1da8851c882adb76c3c9d �[1;94mlatest tag�[0m=v0.0.0
�[1;93m    •�[0m pipe skipped                                   �[1;93mreason�[0m=disabled during snapshot mode
�[1;94m  •�[0m �[1mparsing tag�[0m
�[1;94m  •�[0m �[1msetting defaults�[0m
�[1;94m  •�[0m �[1msnapshotting�[0m
�[1;94m    •�[0m building snapshot...                           �[1;94mversion�[0m=0.0.0-SNAPSHOT-98e80ed
�[1;94m  •�[0m �[1mchecking distribution directory�[0m
�[1;94m  •�[0m �[1mloading go mod information�[0m
�[1;94m  •�[0m �[1mbuild prerequisites�[0m
�[1;94m  •�[0m �[1mwriting effective config file�[0m
�[1;94m    •�[0m writing                                        �[1;94mconfig�[0m=dist/config.yaml
�[1;94m  •�[0m �[1mbuilding binaries�[0m
�[1;94m    •�[0m building                                       �[1;94mbinary�[0m=dist/std_linux_arm64/tyk-pump
�[1;94m    •�[0m building                                       �[1;94mbinary�[0m=dist/std_linux_amd64_v1/tyk-pump
�[1;94m    •�[0m building                                       �[1;94mbinary�[0m=dist/std_linux_s390x/tyk-pump
�[1;94m    •�[0m �[3;2mtook: 5m6s�[0m
�[1;94m  •�[0m �[1marchives�[0m
�[1;94m    •�[0m creating                                       �[1;94marchive�[0m=dist/tyk-pump_0.0.0-SNAPSHOT-98e80ed_linux_s390x.tar.gz
�[1;94m    •�[0m creating                                       �[1;94marchive�[0m=dist/tyk-pump_0.0.0-SNAPSHOT-98e80ed_linux_amd64.tar.gz
�[1;94m    •�[0m creating                                       �[1;94marchive�[0m=dist/tyk-pump_0.0.0-SNAPSHOT-98e80ed_linux_arm64.tar.gz
�[1;94m    •�[0m �[3;2mtook: 15s�[0m
�[1;94m  •�[0m �[1mlinux packages�[0m
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=deb �[1;94march�[0m=arm64 �[1;94mfile�[0m=dist/tyk-pump_0.0.0~SNAPSHOT-98e80ed_arm64.deb
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=deb �[1;94march�[0m=s390x �[1;94mfile�[0m=dist/tyk-pump_0.0.0~SNAPSHOT-98e80ed_s390x.deb
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=deb �[1;94march�[0m=amd64v1 �[1;94mfile�[0m=dist/tyk-pump_0.0.0~SNAPSHOT-98e80ed_amd64.deb
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=rpm �[1;94march�[0m=amd64v1 �[1;94mfile�[0m=dist/tyk-pump-0.0.0~SNAPSHOT-98e80ed.x86_64.rpm
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=rpm �[1;94march�[0m=arm64 �[1;94mfile�[0m=dist/tyk-pump-0.0.0~SNAPSHOT-98e80ed.aarch64.rpm
�[1;94m    •�[0m creating                                       �[1;94mpackage�[0m=tyk-pump �[1;94mformat�[0m=rpm �[1;94march�[0m=s390x �[1;94mfile�[0m=dist/tyk-pump-0.0.0~SNAPSHOT-98e80ed.s390x.rpm
�[1;94m    •�[0m �[3;2mtook: 9s�[0m
�[1;94m  •�[0m �[1mdocker images�[0m
�[1;94m    •�[0m building docker image                          �[1;94mimage�[0m=tykio/tyk-pump-docker-pub:v0.0.0-amd64
�[1;94m    •�[0m building docker image                          �[1;94mimage�[0m=tykio/tyk-pump-docker-pub:v0.0.0-arm64
�[1;94m    •�[0m �[3;2mtook: 1s�[0m
�[1;91m  ⨯�[0m �[1mrelease failed after 5m30s�[0m               �[1;91merror�[0m=docker build failed: failed to build tykio/tyk-pump-docker-pub:v0.0.0-amd64: exit status 1: ERROR: docker exporter does not currently support exporting manifest lists

There are a lot of errors. This is likely a larger issue with the PR and not a small linting/type-checking issue.

This is likely a linting or type-checking issue with the source code. Update the code the changes and avoid modifying the existing tests.

I'm getting the same errors 3 times in a row, so I will stop working on fixing this PR.

@buger buger closed this Aug 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sweep Assigns Sweep to an issue or pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sweep: s390x support for pump
1 participant