Test upgrade suggestions

UAlbertaALTLab · Jun 15, 2024 · 682eff7 · 682eff7
1 parent c7a9d9e
commit 682eff7
Show file tree

Hide file tree

Showing 5 changed files with 5 additions and 4 deletions.
diff --git a/src/CreeDictionary/API/search/test_espt_crk.py b/src/CreeDictionary/API/search/test_espt_crk.py
@@ -49,7 +49,7 @@ def test_search_with_tags(query, has_tags, tags, filtered_query):
                 "expected_query_terms": ["cat"],
                 "expected_new_tags": ["+N", "+Px1Sg", "+Pl"],
                 "slug": "minôs",
-                "expected_inflection": "niminôsak",
+                "expected_inflection": "niminôsimak",
             },
         ],
         [

diff --git a/src/CreeDictionary/CreeDictionary/test_views.py b/src/CreeDictionary/CreeDictionary/test_views.py
@@ -99,7 +99,7 @@ def test_pages_render_without_template_errors(url: str, client: Client, caplog):
     [
         ("niya", None, ["niyanân", "kiyânaw", "kiyawâw", "wiyawâw"]),
         ("awa", "awa@pra", ["ôma", "awa", "ana"]),
-        ("minôs", None, ["minôs", "minôsa", "niminôs"]),
+        ("minôs", None, ["minôs", "minôsa", "niminôsim"]),
     ],
 )
 def test_retrieve_paradigm(

diff --git a/src/CreeDictionary/tests/API_tests/model_test.py b/src/CreeDictionary/tests/API_tests/model_test.py
@@ -323,6 +323,7 @@ def test_search_results_order(query: str, top_result: str, later_result: str):
     ), f"{top_result} did not come before {later_result}"
 
 
+@pytest.mark.skip(reason="New FSTs do not fail on this situation.  Note this skip may reintroduce regressions.  If that happens we'll get a replacement test case.")
 @pytest.mark.django_db
 def test_logs_error_on_analyzable_result_without_generated_string(caplog):
     """

diff --git a/src/CreeDictionary/tests/test_fst_regressions.py b/src/CreeDictionary/tests/test_fst_regressions.py
@@ -16,7 +16,7 @@
             # See: https://github.com/UAlbertaALTLab/morphodict/issues/897
             "ê-pim-nêhiyawêyahk",
             RichAnalysis(
-                (("PV/e+", "PV/pimi+"), "nêhiyawêw", ("+V", "+AI", "+Cnj", "+12Pl"))
+                (("PV/e+", "PV/pimi+"), "nêhiýawêw", ("+V", "+AI", "+Cnj", "+12Pl"))
             ),
         ),
         (

diff --git a/src/crkeng/app/integration_tests/test_paradigm_manager.py b/src/crkeng/app/integration_tests/test_paradigm_manager.py
@@ -69,7 +69,7 @@ def test_generates_na_paradigm(paradigm_manager) -> None:
     """
     lemma = "minôs"
     word_class = "NA"
-    inflections = ["minôsa", "minôsak", "niminôs"]
+    inflections = ["minôsa", "minôsak", "niminôsim"]
 
     default_size = first(paradigm_manager.sizes_of(word_class))
     paradigm = paradigm_manager.paradigm_for(word_class, lemma=lemma, size=default_size)