Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update flake8 and clang-tidy linters #179

Merged
merged 18 commits into from
Oct 18, 2023

Conversation

patrick-5546
Copy link
Member

@patrick-5546 patrick-5546 commented Oct 18, 2023

Description

Future steps

Once the bug fix has been merged:

To do

Verification

  • CI passes when no lint errors
  • CI fails when there are lint errors

Resources

@patrick-5546 patrick-5546 requested a review from hhenry01 October 18, 2023 17:32
@patrick-5546 patrick-5546 self-assigned this Oct 18, 2023
@patrick-5546 patrick-5546 added the path Pathfinding team label Oct 18, 2023
@patrick-5546
Copy link
Member Author

patrick-5546 commented Oct 18, 2023

Not noticeably faster than previous implementation in CI (8-10min -> 7-8). However on my local machine it goes from 2.5min to 0.5min. Not sure if it is CPU or memory constrained in CI (has 2 cores and 7GB RAM). Could play around with the number of parallel jobs (currently 16)

@patrick-5546
Copy link
Member Author

Reduction in CI runtimes come from the fact that we are now not running clang-tidy during build.

  • colcon-test: 5min -> 2min
  • clang-tidy: 7min -> 4min

@patrick-5546 patrick-5546 enabled auto-merge (squash) October 18, 2023 19:24
@patrick-5546 patrick-5546 merged commit b2226ec into main Oct 18, 2023
@patrick-5546 patrick-5546 deleted the patrick-5546/improve-clang-tidy branch October 18, 2023 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ctrl Controller team infrastructure path Pathfinding team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Clang tidy takes a long time
2 participants