Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lint-changed-files without installing package #317

Merged
merged 5 commits into from
Nov 5, 2024
Merged

Conversation

d-morrison
Copy link
Member

No description provided.

@d-morrison d-morrison changed the title don't try to install the package; just lint all changed files. lint-changed-files without installing package Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comment on lines -22 to -26
extra-packages: |
packages: |
any::gh
any::lintr
any::purrr
needs: check
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the default version of this GHA installs the package, along with its dependencies; that doesn't seem necessary and takes a lot of time, so I'm removing those steps and just installing the bare minimum to run {lintr}

Comment on lines -33 to -35
- name: Install package
run: R CMD INSTALL .

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is where {serocalculator} would get installed

@d-morrison d-morrison marked this pull request as ready for review November 5, 2024 17:39
@d-morrison d-morrison merged commit cbefd9c into main Nov 5, 2024
14 checks passed
@d-morrison d-morrison deleted the lint-changed-faster branch November 5, 2024 17:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant