Local score low pass filtering #151
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Created a function for building low pass filter - Created a function that performs convolution (filters data with low pass filter) - Added in a function that encapsulates the two functions mentioned above - Added in docstrings - Added in asssert statements
- Allows a user to define whether or not to filter the local score arrays - they must define a normalized cutoff frequency and the order of the filter - A future feature could be to find some default numbers that seem to work well enough and allow a user to just pick True
- fixed some type assertion problems in all files
|
It should also be verified that these results work with the tweetynet pipeline. The way I wrote it, I think it is fine, but needs to be verified. |
|
We will also need to update the readme.md file with the new isolation parameter. |
- annotation chunker wasn't writing the folder to the output
|
It works with the tweetynet pipeline! The readme file just needs to be updated with the new isolation parameters. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added in the ability of a user to filter the local score arrays using a butterworth low pass filter.
TODO