Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYC-1812 - Collection page masonry view errors #1049

Merged
merged 1 commit into from
Nov 14, 2023
Merged

HYC-1812 - Collection page masonry view errors #1049

merged 1 commit into from
Nov 14, 2023

Conversation

bbpennel
Copy link
Member

https://unclibrary.atlassian.net/browse/HYC-1812

  • Comment out CatalogController lines which were setting up bookmark behaviors, since we have disabled the routes for it. Removing these lines resolves undefined method bookmark_path'errors directly, and seem to indirectly resolve the originalguest_uid_authentication_key` error. See the ticket for more details.

Copy link
Contributor

@sharonluong sharonluong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a reason why we can't just delete these lines?

@bbpennel
Copy link
Member Author

They get generated as part of the base version of CatalogController, so I guess I left them in to make comparing against the default easier. I can remove them if you think they should go though.

@sharonluong
Copy link
Contributor

@bbpennel ah ok that makes sense then

@sharonluong sharonluong merged commit e9ea752 into main Nov 14, 2023
2 checks passed
@bbpennel bbpennel deleted the hyc-1812 branch February 13, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants