Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HYC-1354 - Fallback Thumbnails #1133

Merged
merged 25 commits into from
Dec 5, 2024
Merged

HYC-1354 - Fallback Thumbnails #1133

merged 25 commits into from
Dec 5, 2024

Conversation

davidcam-src
Copy link
Contributor

@davidcam-src davidcam-src commented Nov 26, 2024

https://unclibrary.atlassian.net/browse/HYC-1354

  • Issues with default thumbnails showing up for works with existing filesets after deleting the first is caused by the representative_id field not updating after the first file attached is deleted
  • Encountered some issues trying to update the field during the delete operation, made changes to some presenters and views instead

  • Implemented override for retrieve_values in Blacklight's thumbnail presenter to substitute a work's thumbnail path with the thumbnail path for the first associated fileset if it's the default
  • Changed representative media partial to rely on a custom function fetch_primary_fileset_id instead of representative_id so the first fileset id is substituted if it's nil
  • Use fetch_primary_fileset_id in place of representative_id forrepresentative_presenter in the work_show_presenter
  • Decrease the amount of filesets needed to render the File Manager button on work show pages from 2 to 1
  • Change load to require_dependency to lessen frequency of errors in local environments caused by loading the same override multiple times

@davidcam-src davidcam-src merged commit a4fb320 into main Dec 5, 2024
4 checks passed
@davidcam-src davidcam-src deleted the hyc-1354 branch December 5, 2024 20:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants