Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expanded structs to support clock and double fields #60

Merged
merged 7 commits into from
Sep 1, 2023
Merged

Expanded structs to support clock and double fields #60

merged 7 commits into from
Sep 1, 2023

Conversation

thorulf4
Copy link
Contributor

No description provided.

mikucionisaau
mikucionisaau requested changes Aug 31, 2023
View reviewed changes
Copy link
Member

@mikucionisaau mikucionisaau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but I need more confidence with the functionality (please add more tests, in particular those that are supposed to fail)

test/test_parser.cpp Show resolved Hide resolved
test/test_typechecker.cpp Show resolved Hide resolved
@thorulf4 thorulf4 merged commit b3a2909 into UPPAALModelChecker:main Sep 1, 2023
5 checks passed
@thorulf4 thorulf4 deleted the expanded_structs branch September 1, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mikucionisaau mikucionisaau mikucionisaau approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@thorulf4 @mikucionisaau