Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allows implicit clock to double conversions in ternary conditional operators during type checking #61

Merged
merged 15 commits into from
Sep 15, 2023

Conversation

thorulf4
Copy link
Contributor

@thorulf4 thorulf4 commented Aug 25, 2023

Modifies Ternary conditional operators i.e condition? expression1 : expression2

I've added return type to INLINE_IF expressions, instead of assuming both operands have the same type. Which allows implicit conversions to work in in this such expressions.

Depends on and must be merged with https://github.com/UPPAALModelChecker/uppaal/pull/1192

Copy link
Member

@mikucionisaau mikucionisaau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add more tests

test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
include/utap/typechecker.h Show resolved Hide resolved
test/test_typechecker.cpp Outdated Show resolved Hide resolved
@thorulf4 thorulf4 merged commit 1b59317 into UPPAALModelChecker:main Sep 15, 2023
5 checks passed
@thorulf4 thorulf4 deleted the ternery_operator branch September 15, 2023 07:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants