Fixed issue with type deduced expressions breaking ternary operators #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
first, when computing a common type and second when assigning.
| if (!areInlineIfCompatible(expr.get_type(), expr[1].get_type(), expr[2].get_type())) { | ||
|
|
||
| type = getInlineIfCommonType(expr[1].get_type(), expr[2].get_type()); | ||
| if (!areInlineIfCompatible(type, expr[1].get_type(), expr[2].get_type())) { |
There was a problem hiding this comment.
It should be possible to convert the common type to the resulting type
Suggested change
| if (!areInlineIfCompatible(type, expr[1].get_type(), expr[2].get_type())) { | |
| if (!areAssignmentCompatible(resultType, type)) { |
There was a problem hiding this comment.
I'm not sure what resultType is supposed to be. But areInlineIfCompatible call does areAssignmentCompatible checks
There was a problem hiding this comment.
given the expression res = (c) ? (a) : (b) then the resultType is the type of res.
|
I've run regression and uppaal tests, both succeed |
mikucionisaau
approved these changes
Sep 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.