add PR template validation #248
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ghg-demo ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
PR description is too short and seems to not fulfill PR template, please fill in |
stephenkilbourn
requested review from
hanbyul-here and
j08lue
and removed request for
hanbyul-here
1 task
|
I think we still need a better PR template and can then consider adding a checker that people actually use it. Closing for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What am I changing and why
I've added a bit of clarification on the PR template and then added a github action to validate that a description other than the text in the
PULL_REQUEST_TEMPLATE.mdis used.How to test
This can be seen by creating a PR and not editing the template. Screenshot of that case:
Now that the template is edited, look to see that the test step has passed.
veda-uisubmodule is needed and only done so if that's the case.