Skip to content

Commit

Permalink
Fix issue with social share buttons.
Browse files Browse the repository at this point in the history
`site.url` does not contain the domain of the site, which breaks social buttons.
This attempts to resolve what looks like a misconfiguration of Jekyll to correctly generate the URLs.

Closes #1201
  • Loading branch information
aholmes committed Jun 28, 2023
1 parent 6b36af7 commit 0d78483
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 5 deletions.
3 changes: 0 additions & 3 deletions .circleci/config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,7 @@ build_jekyll: &build_jekyll
command: |
if [ -z "$CIRCLECI_TRIGGER" ]; then
echo "Building RSE Blog for Preview"
cp ~/repo/.circleci/circle_urls.sh ~/repo/circle_urls.sh
cd ~/repo
chmod u+x circle_urls.sh
bash circle_urls.sh
bundle exec jekyll build
else
echo "Nightly build detected, preview not needed."
Expand Down
4 changes: 2 additions & 2 deletions _config.yml
Original file line number Diff line number Diff line change
Expand Up @@ -4,8 +4,8 @@ lang: en
title: US-RSE
description: United States Research Software Engineer Association

url: ""
baseurl: "" # for testing, also check .circleci/circle_urls.sh
url: https://usrse.org
baseurl: ""
title-img: /assets/img/main_logo_transparent.png # baseurl will be prepended
twitter-img: /assets/img/main_logo_transparent.png # url + baseurl will be prepended
banner: /assets/img/main_logo_transparent.png
Expand Down

0 comments on commit 0d78483

Please sign in to comment.