Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Facebook and LinkedIn "Share buttons" on blog posts are broken #1201

Closed
lparsons opened this issue Jun 27, 2023 · 4 comments · Fixed by #1205
Closed

Facebook and LinkedIn "Share buttons" on blog posts are broken #1201

lparsons opened this issue Jun 27, 2023 · 4 comments · Fixed by #1205

Comments

@lparsons
Copy link
Member

Clicking on the "Share" button at the bottom of a post for Facebook and LinkedIn leads to an error. The Twitter and Reddit links seem to work.

Example Post: https://us-rse.org/2023-06-26-pride-spotlight-lynn-conway/

Facebook
image

LinkedIn
image
@lrasmus
Copy link
Contributor

lrasmus commented Jun 27, 2023

It looks like the links to be shared are not including the full URL.

E.g., Facebook is https://www.facebook.com/share.php?u=/2023-06-26-pride-spotlight-lynn-conway/

But should be https://www.facebook.com/share.php?u=https://us-rse.org/2023-06-26-pride-spotlight-lynn-conway/

This affects all of the links, it just appears as errors in LinkedIn and Facebook who are detecting that it's not a fully qualified URL

@lrasmus
Copy link
Contributor

lrasmus commented Jun 27, 2023

Not sure entirely about how Jekyll works and our setup, but I can see we are referencing site.url (e.g., https://github.com/USRSE/usrse.github.io/blob/main/_includes/buttons/share-buttons.html#L4)

But in our config file, site.url is blank:
https://github.com/USRSE/usrse.github.io/blob/main/_config.yml#L7-L8

So it makes sense why the full URL isn't showing, but I'm not sure when/why this was changed.

@lrasmus
Copy link
Contributor

lrasmus commented Jun 27, 2023

This appears to be the commit where it was changed. I'm not seeing any specific reason to have url empty, so I will propose a PR to bring it back.

lrasmus added a commit to lrasmus/usrse.github.io that referenced this issue Jun 27, 2023
@lrasmus
Set url in site config
1dc7c53 
This should address issue USRSE#1201 where sharing links weren't working because site.url was blank (because url is blank in _config.yml).
@lrasmus lrasmus mentioned this issue Jun 27, 2023
Closed
2 tasks
@aholmes
Copy link
Contributor

aholmes commented Jun 28, 2023

This issue extends to all references to the site.url variable. For example, the "inclusive definition" link here does not include the domain.

aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Fix issue with links missing site domain.
0d4d0ec 
- Attempt to update `site.url` variable during circleci build.

Closes USRSE#1201
@aholmes aholmes mentioned this issue Jun 28, 2023
Closed
2 tasks
aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Fix issue with social share buttons.
0d78483 
`site.url` does not contain the domain of the site, which breaks social buttons.
This attempts to resolve what looks like a misconfiguration of Jekyll to correctly generate the URLs.

Closes USRSE#1201
aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Remove unused script.
d36ca5b 
Closes USRSE#1201
aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Fix typo in domain.
c8d2998 
Closes USRSE#1201
aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Fix issue with social share buttons.
89b64f7 
`site.url` does not contain the domain of the site, which breaks social buttons.
This attempts to resolve what looks like a misconfiguration of Jekyll to correctly generate the URLs.

Closes USRSE#1201

Remove unused script.

Closes USRSE#1201

Fix typo in domain.

Closes USRSE#1201
aholmes added a commit to aholmes/usrse.github.io that referenced this issue Jun 28, 2023
@aholmes
Fix issue with social buttons.
d3a6210 
The `site.url` variable needs to be the site domain.
The absence of a value causes URLs using `site.url` to not
contain this, which then prevents social sites from linking
to the site.

This change fixes the `site.url` variable and maintains
the circleci build behavior to maintain preview of assets.

Closes USRSE#1201
@aholmes aholmes mentioned this issue Jun 28, 2023
Merged
2 tasks
cmaimone pushed a commit that referenced this issue Jun 29, 2023
@aholmes
Fix issue with social buttons. (#1205)
41f4fbd 
The `site.url` variable needs to be the site domain.
The absence of a value causes URLs using `site.url` to not
contain this, which then prevents social sites from linking
to the site.

This change fixes the `site.url` variable and maintains
the circleci build behavior to maintain preview of assets.

Closes #1201
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@aholmes @lparsons @lrasmus