Fix issue with links missing site domain. #1204
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Attempt to update `site.url` variable during circleci build. Closes USRSE#1201
aholmes
force-pushed
the
1201_fix_site_url
branch
from
0d4d0ec
to
0d78483
Compare
`site.url` does not contain the domain of the site, which breaks social buttons. This attempts to resolve what looks like a misconfiguration of Jekyll to correctly generate the URLs. Closes USRSE#1201 Remove unused script. Closes USRSE#1201 Fix typo in domain. Closes USRSE#1201
aholmes
force-pushed
the
1201_fix_site_url
branch
from
c8d2998
to
89b64f7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
site.urlis empty causing all links to exclude the site domain. This causes issues with "social" share buttons.Jekyll appears to have been misconfigured.
site.urlshould be the domain/protocol/etc. whilesite.baseurlshould be the root directory that the site is served from. In this case, the site is served from/sosite.baseurlshould be empty.Removing the script that alters the config and updating
site.urlfixes the share buttons and leaves any usages ofsite.baseurlunchanged.Closes #1201
Checklist: