Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create organizational_membership #1543

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

Conversation

sandragesing
Copy link
Contributor

@sandragesing sandragesing commented Jul 19, 2024

Description

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@cmaimone
Copy link
Contributor

It looks like from the files there should be an organizational-membership page? But there isn't one in the artifacts.

Under "Get Involved" section, the "organizational membership" menu item links to: get-involved/index.html -- where the information could really benefit from it's own section/header, because it's lost with the yellow box about Slack.

From /join/index.html, the left "organizational membership" link seems to link back to /join/index.html -- I did not see the organizational membership info the first 3 times I looked at the page, so again, can we separate it out? I also would caution against mentioning organizational membership in the same individual section that emphasizes that membership is free, since organizational membership won't be.

To-dos:

  • Can you make separate sections on join.md and the get involved page for organizational membership info? So it's easier to find and clearly separated from the existing individual membership info?
  • If there's supposed to be a dedicated organizational membership page, something went wrong. Can you check on that?

@sandragesing
Copy link
Contributor Author

I addressed all comments. Thanks Christina!

@cmaimone
Copy link
Contributor

@sandragesing Some checks are failing. Some are links that can be ignored, but this one is part of your edits:
/github/workspace/pages/get_involved/join.md:
❌️ https://us-rse.org/org-membership

Under the "Get Involved" menu, the "Organizational Membership" entry is still pointing to the join page, not the new organizational membership page. This is also why there's no menu on the left on the org membership page: https://output.circle-artifacts.com/output/job/2c7fbfbe-e252-4c89-a3e4-fa58c9f27da0/artifacts/0/usrse.github.io/org-membership/index.html

The links are still not rendering on the org-membership page: https://output.circle-artifacts.com/output/job/2c7fbfbe-e252-4c89-a3e4-fa58c9f27da0/artifacts/0/usrse.github.io/org-membership/index.html While it seems like it should work, because those links are within html tags (in the list), I think the markdown isn't rendering - I'd either use markdown for the list, or convert the links in the list to html. Note that the link for your email at the bottom does render correctly, which also suggests something about the html/markdown mix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants