Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added DEI WG Aug 8 2024 meeting #1552

Merged
merged 2 commits into from
Aug 8, 2024
Merged

Conversation

lparsons
Copy link
Member

@lparsons lparsons commented Aug 2, 2024

Description

Checklist:

  • I have previewed changes locally or with CircleCI (runs when PR is created)
  • I have completed any content reviews, such as getting input from relevant working groups. If no, please note this and wait to post the PR to the #website channel until the content has been settled.

When you are ready for a technical review/merge, post the for the link for the PR in the US-RSE Slack (#website) to ask for reviewers.

@lparsons lparsons marked this pull request as ready for review August 2, 2024 19:52
@lparsons
Copy link
Member Author

lparsons commented Aug 2, 2024

@exoticDFT Content review when you get the chance, thanks!

Comment on lines 10 to 11
- - start: 2024-08-08 14:00 EST
end: 2024-08-08 15:00 EST
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EST actually makes the events show up as 1500ET or 1200PT on the add to calendar button, the calendar event, etc. I think you have to use ET instead of EST. Another minor issue with our datetime system

Suggested change
- - start: 2024-08-08 14:00 EST
end: 2024-08-08 15:00 EST
- - start: 2024-08-08 14:00 ET
end: 2024-08-08 15:00 ET

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooops, my bad on that one. Good catch @exoticDFT. I just removed the TZ altogether and used UTC time.

Updated previews:

The broken URL seems unrelated and I'm not sure of the proper fix atm:

🤔 Uh oh... The following urls did not pass:
/github/workspace/_posts/2022-06-04-info-interview-form-rse-group.md:
❌️ https://www.nrel.gov/research/staff/rafael-mudafort.html

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I notified Rafael and he's taking it up with NREL IT. I propose that it is safe to ignore.

@exoticDFT exoticDFT merged commit 89b2d7e into USRSE:main Aug 8, 2024
1 of 2 checks passed
@crd477
Copy link
Contributor

crd477 commented Aug 9, 2024

It appears that the deleted file is still referenced from: _posts/2024-06-01-pride-month.md. Can you suggest a fix for that file?

@lparsons
Copy link
Member Author

lparsons commented Aug 9, 2024

It appears that the deleted file is still referenced from: _posts/2024-06-01-pride-month.md. Can you suggest a fix for that file?

Whoops! Sorry about that. I think I should expire that repeated event instead. Let me submit a PR to try and fix things. Thanks for the heads up and sorry for the extra trouble.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants