Permission relationship #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elskater98
reviewed
Mar 6, 2024
|
|
||
| @Entity | ||
| @Setter |
There was a problem hiding this comment.
It's not necessary to use annotation getters and setters, If you use the annotation data
jorgechp
previously approved these changes
Mar 19, 2024
|
PR OK. But there is a conflict that need to be solved before I can merge your code. Thanks!! |
rogargon
reviewed
Mar 25, 2024
| @Data | ||
| @EqualsAndHashCode(callSuper = false) | ||
| public class Permission { | ||
|
|
||
| @Id | ||
| @GeneratedValue |
There was a problem hiding this comment.
It is better to make the generation method explicit to make sure it is unique, like: @GeneratedValue(strategy = GenerationType.IDENTITY)
| import org.springframework.data.repository.CrudRepository; | ||
| import org.springframework.data.repository.PagingAndSortingRepository; | ||
|
|
||
| public interface PermissionRepository extends CrudRepository<Permission, String>, PagingAndSortingRepository<Permission, String> { |
There was a problem hiding this comment.
If permission has Long as identifier, then the repository should use Long as identity type instead of String
rogargon
approved these changes
Apr 7, 2024
rogargon
approved these changes
Apr 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relationship of the permission class