Added Version to Scanner, fixed ScanRunner interface bug #125
Conversation
| @@ -94,6 +98,55 @@ func (s *Scanner) Streamer(stream io.Writer) *Scanner { | |||
| return s | |||
| } | |||
|
|
|||
| // Version returns the version of the installed nmap binary | |||
| func (s *Scanner) Version() (result any, err error) { | |||
There was a problem hiding this comment.
| func (s *Scanner) Version() (result any, err error) { | |
| func (s *Scanner) Version() (string, error) { |
I recommend never using named return parameters when the function signature is implicitly clear enough without.
| @@ -94,6 +98,55 @@ func (s *Scanner) Streamer(stream io.Writer) *Scanner { | |||
| return s | |||
| } | |||
|
|
|||
| // Version returns the version of the installed nmap binary | |||
There was a problem hiding this comment.
| // Version returns the version of the installed nmap binary | |
| // Version returns the version of the used nmap binary. |
This is more correct, since multiple nmap binaries can be installed, but only one is in use by the library at any given time.
| result = splitted[2] | ||
| break |
There was a problem hiding this comment.
| result = splitted[2] | |
| break | |
| return res[2], nil |
| splitted := strings.Split(m, " ") | ||
| if len(splitted) >= 2 { |
There was a problem hiding this comment.
| splitted := strings.Split(m, " ") | |
| if len(splitted) >= 2 { | |
| res:= strings.Split(m, " ") | |
| if len(res) >= 2 { |
| errScanner := bufio.NewScanner(stderr) | ||
| var errorOutput = []string{} | ||
| for errScanner.Scan() { | ||
| m := errScanner.Text() | ||
| errorOutput = append(errorOutput, m) | ||
| } | ||
|
|
||
| err = cmd.Wait() | ||
| if err != nil { | ||
| return | ||
| } | ||
|
|
||
| if len(errorOutput) > 0 { | ||
| return nil, fmt.Errorf("%v", errorOutput) | ||
| } |
There was a problem hiding this comment.
What is the purpose of this code? To check that we can run the binary without errors on top of getting the version info? If yes, these should be two separate functions IMO.
There was a problem hiding this comment.
I will check all your comments and will make the proposed changes in the first calendar week of december.
I'm really busy at the moment.
There was a problem hiding this comment.
No rush, take all the time you need! :) Thanks again!
No description provided.